Fix DynaCool driver init and temperature_setpoint cache update#8097
Open
SherwanMicrosoft wants to merge 1 commit intomicrosoft:mainfrom
Open
Conversation
- block_while_ramping_temperature: use set_cmd=None/get_cmd=None so the parameter is settable instead of read-only (set_cmd=False rejected the supplied initial_value). - blocking_t_state_check_interval: drop duplicate instrument=self kwarg; add_parameter already provides it. - _set_temperature_and_state: update cache on self.temperature_setpoint, not the non-existent self.setpoint.
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes three bugs in
qcodes.instrument_drivers.QuantumDesign.DynaCoolPPMS.DynaCool.DynaCoolthat prevented the driver from instantiating against a real PPMS DynaCool and
from updating the
temperature_setpointcache after a temperature ramp.Encountered while bringing up an SdH measurement on a Quantum Design PPMS DynaCool
on QCoDeS 0.57.0; all three issues are present on
mainas well.Changes
block_while_ramping_temperatureparameter (~line 84) — created withset_cmd=False/get_cmd=False, which makes the parameter read-only andcauses
add_parameterto reject the suppliedinitial_value=False. Changedto
set_cmd=None/get_cmd=Noneso the parameter behaves as acache-only settable, matching the existing docstring intent
("when set to True, will block further interaction…").
blocking_t_state_check_intervalparameter (~line 93) —add_parameteralready passes
instrument=selfautomatically; the duplicate keyword raiseda
TypeErroron driver construction. Removed._set_temperature_and_statecache update (~line 436) — referencedself.setpoint, which doesn't exist on this class. The correspondingparameter is
self.temperature_setpoint. Fixed.Test plan
Manually instantiated the driver against the real PPMS hardware
(
TCPIP0::10.164.120.28::5000::SOCKET) and exercised:temperature_setpoint(...)round-trip (previously raisedAttributeErrorinside the blocking branch on parameter 3)
No new tests added; these are integration-only paths against vendor hardware.
Newsfragment
Added under
docs/changes/newsfragments/+dynacool-fixes.improved_driver(will be renamed to
<PR-number>.improved_driveronce the PR number isassigned).