feat: ACR-based SDK distribution with feature flag by CodingIsBliss · Pull Request #2837 · microsoft/Oryx

CodingIsBliss · 2026-04-01T07:44:11Z

Summary

Add ACR-based SDK distribution behind ORYX_ENABLE_ACR_SDK_PROVIDER feature flag. SDKs can be pulled from Azure Container Registry instead of blob storage, with two separate provider paths and full fallback to existing blob storage.

Architecture

Two separate ACR SDK providers:

ExternalAcrSdkProvider - Communicates with LWASv2 via Unix socket (source=acr). LWASv2 resolves the SDK companion image from LinuxAssets (same build tag as runtime image), pulls via containerd, mounts, and extracts SDK to disk.
AcrSdkProvider (direct) - Downloads SDKs directly from Oryx ACR (oryxsdks.azurecr.io) using OCI Distribution API via curl/HTTP. Used as a fallback when LWASv2 is not available.

Fallback Chain

ExternalAcrSdkProvider (LWASv2 -> WAWS ACR companion image)
GetAcrInstallerScriptSnippet (direct curl -> Oryx ACR)
EnableDynamicInstall (existing blob storage - untouched)

New Files (8)

IExternalAcrSdkProvider.cs / ExternalAcrSdkProvider.cs - ACR SDK provider via LWASv2
OciRegistryClient.cs - HTTP client for OCI Distribution API
AcrVersionProviderBase.cs - Base class for ACR version discovery
Per-platform ACR version providers: Node, Python, PHP, DotNetCore

Modified Files (27)

Constants/Config: SdkStorageConstants, SettingsKeys, Options
Platform install decisions: Node/Python/PHP/DotNet Platform.cs with ACR branch
Version providers: ACR provider chain added
Installers: GetAcrInstallerScriptSnippet() for direct OCI download
DI registrations for all new providers
Go startup: ACR download path in setupEnvironment.go

Feature Flag

ORYX_ENABLE_ACR_SDK_PROVIDER (default: false)
ORYX_ACR_SDK_REGISTRY_URL (default: https://oryxsdks.azurecr.io)

All changes additive. Existing blob storage paths untouched.

Related PRs

Antares-Websites: #15250811
AAPT-Antares-Oryx: #15250812
imagebuilder-v2: #15250813

Add two separate ACR SDK providers behind ORYX_ENABLE_ACR_SDK_PROVIDER: 1. ExternalAcrSdkProvider - communicates with LWASv2 via Unix socket to pull SDK images from WAWS Images ACR 2. AcrSdkProvider (direct) - downloads SDKs from Oryx ACR (oryxsdks.azurecr.io) using OCI Distribution API New files: - IExternalAcrSdkProvider.cs / ExternalAcrSdkProvider.cs - OciRegistryClient.cs - HTTP client for OCI Distribution API - AcrVersionProviderBase.cs - base class for ACR version discovery - Per-platform ACR version providers (Node, Python, PHP, DotNetCore) - publishSdkImageToAcr.sh / publishSdkToAcr.yml - ACR publish pipeline Modified files: - Platform install decisions (NodePlatform, PythonPlatform, PhpPlatform, DotNetCorePlatform) with ACR branch before existing DynamicInstall - Version provider orchestrators with ACR provider chain - PlatformInstallerBase with GetAcrInstallerScriptSnippet() - Go startup script generator with ACR download path - DI registrations for all new providers - Constants, options, settings keys for ACR configuration All changes are additive and behind feature flags. Existing blob storage code paths are completely untouched.

…esolution Remove ACR repository/tag construction from ExternalAcrSdkProvider. Now sends only platform, version, and debianFlavor to LWASv2. LWASv2 resolves the SDK companion image from LinuxAssets and handles pinning, containerd pull, mount, and extraction.

… OneBranch pipeline) Remove publishSdkImageToAcr.sh and publishSdkToAcr.yml since SDK images are now built and pushed using onebranch.pipeline.imagebuildinfo in the AAPT-Antares-Oryx pipeline, not via custom scripts.

Use the same ACR that AAPT-Antares-Oryx publishes SDK images to. Updated both C# constant and Go constant.

- SA1204: Move static GetFirstLayerDigest before instance members (OciRegistryClient.cs) - SA1124: Remove #region/#endregion around OCI JSON models (OciRegistryClient.cs) - SA1202: Move protected GetAcrInstallerScriptSnippet before private methods (PlatformInstallerBase.cs) - SA1116/SA1117: Place multi-line parameters each on own line (ExternalAcrSdkProvider.cs) - SA1515: Add blank line before single-line comment (DotNetCoreAcrVersionProvider.cs)

* fix: Resolve StyleCop analyzer errors in ACR SDK provider files - SA1204: Move static GetFirstLayerDigest before instance members (OciRegistryClient.cs) - SA1124: Remove #region/#endregion around OCI JSON models (OciRegistryClient.cs) - SA1202: Move protected GetAcrInstallerScriptSnippet before private methods (PlatformInstallerBase.cs) - SA1116/SA1117: Place multi-line parameters each on own line (ExternalAcrSdkProvider.cs) - SA1515: Add blank line before single-line comment (DotNetCoreAcrVersionProvider.cs) * fix sdk providers logic * refactor pythonPlatform * refctor for dotnet,php and node --------- Co-authored-by: Sarath chandra Bussa <sbussa@microsoft.com>

sarsharma · 2026-04-02T08:48:53Z

Maybe we need 2 config flags here?
ORYX_ENABLE_EXTERNAL_ACR_SDK_PROVIDER
ORYX_ENABLE_ACR_SDK_PROVIDER

…m/microsoft/Oryx into feature/oryx-sdk-acr-distribution

This reverts commit 77d9f99.

…LWASv2 socket contract - Fix socket path to /var/sdk-image-sockets/oryx-pull-sdk-image.socket (ACR socket) - Add ExternalAcrSdksStorageDir constant (/var/OryxAcrSdks) for ACR SDK cache - Add top-level Action field (pull-sdk / get-version) to request DTOs - Remove BlobName and UrlParameters from ExternalAcrSdkProvider request - Accept server-returned filename as success response instead of expecting 'Success$'

* update logic for dotnet and default versions * Refactor ACR SDK provider to return tarball path

sarsharma · 2026-04-04T10:55:39Z

src/BuildScriptGenerator.Common/SdkStorageConstants.cs

+        public const string EnableExternalAcrSdkProviderKey = "ORYX_ENABLE_EXTERNAL_ACR_SDK_PROVIDER";
+        public const string EnableAcrSdkProviderKey = "ORYX_ENABLE_ACR_SDK_PROVIDER";
+        public const string AcrSdkRegistryUrlKeyName = "ORYX_ACR_SDK_REGISTRY_URL";
+        public const string DefaultAcrSdkRegistryUrl = "https://oryxacr.azurecr.io";


before merging, lets update this to mcr if required

sarsharma · 2026-04-04T11:01:45Z

src/BuildScriptGenerator.Common/SdkStorageConstants.cs

+        public const string EnableAcrSdkProviderKey = "ORYX_ENABLE_ACR_SDK_PROVIDER";
+        public const string AcrSdkRegistryUrlKeyName = "ORYX_ACR_SDK_REGISTRY_URL";
+        public const string DefaultAcrSdkRegistryUrl = "https://oryxacr.azurecr.io";
+        public const string AcrSdkRepositoryPrefix = "sdks";


same here, for prod case + mcr, this might become <mcr>/oryx/sdks

…po constants (#2867) * update logic for dotnet and default versions * Refactor ACR SDK provider to return tarball path * Cleanup startupscriptgen and refactor ACR SDK distribution constants

* update logic for dotnet and default versions * Refactor ACR SDK provider to return tarball path * Cleanup startupscriptgen and refactor ACR SDK distribution constants * Refactor ACR SDK provider methods to return boolean status and update related logic across platforms * Update version provider logic to check for external SDK provider option

Sarath chandra Bussa added 4 commits April 1, 2026 13:14

feat: Oryx SDK regional distribution — pull SDKs from ACR

e6e98cd

CodingIsBliss changed the title ~~Oryx SDK regional distribution — pull SDKs from ACR~~ feat: ACR-based SDK distribution with feature flag Apr 1, 2026

fix: Default ACR SDK registry to oryxacr.azurecr.io

faa6b2d

Use the same ACR that AAPT-Antares-Oryx publishes SDK images to. Updated both C# constant and Go constant.

CodingIsBliss force-pushed the feature/oryx-sdk-acr-distribution branch from 259f0c4 to faa6b2d Compare April 1, 2026 13:09

Sarath chandra Bussa added 2 commits April 1, 2026 19:22

CodingIsBliss force-pushed the feature/oryx-sdk-acr-distribution branch from 505580f to 3a88dfe Compare April 1, 2026 14:19

kumaraksh1 and others added 9 commits April 1, 2026 20:41

latest pull

78c75d3

fix build and tests (#2843)

962a3a3

fix to fetch from acr (#2844)

7d8e4ea

Update version providers (#2845)

ccafe60

Refactor version providers (#2846)

4f0262e

Fix acr version info (#2848)

0b24751

Changes for php composer (#2849)

061b3c9

Clean dead code (#2850)

268a682

kumaraksh1 and others added 10 commits April 2, 2026 14:30

Fix priroity in sdk resolver (#2851)

c2e1e23

Fix Uts and version providers (#2852)

dd2367f

ACR Sdk provider refactor (#2854)

c427f24

registryclient improvements

f9de4e6

Merge branch 'feature/oryx-sdk-acr-distribution' of https://github.co…

7e429cb

…m/microsoft/Oryx into feature/oryx-sdk-acr-distribution

fix build issue

8ae6264

Add changes foe external ACR provider (#2855)

bda3623

Change flag name for external acr case (#2856)

04e1b11

Handle multiplatform (#2857)

77d9f99

Revert "Handle multiplatform (#2857)" (#2858)

6808271

This reverts commit 77d9f99.

kumaraksh1 added 2 commits April 3, 2026 17:36

Disable external ACR for multiplatform (#2859)

476b64f

Fix test case (#2860)

dda3a96

CodingIsBliss marked this pull request as ready for review April 3, 2026 14:10

CodingIsBliss requested a review from a team as a code owner April 3, 2026 14:10

CodingIsBliss marked this pull request as draft April 3, 2026 14:11

kumaraksh1 and others added 7 commits April 4, 2026 01:45

Refactor external acr provider (#2862)

eb2f4e8

update externalacrsdkprovider contract

69cd61e

update logic for dotnet and default versions (#2864)

5d8b2f7

Refactor code for new acr way (#2863)

03e68ed

nit fix (#2865)

1516468

ACR SDK distribution: Refactor direct acr sdk fetching logic (#2866)

e10bcf5

* update logic for dotnet and default versions * Refactor ACR SDK provider to return tarball path

sarsharma reviewed Apr 4, 2026

View reviewed changes

sarsharma added 2 commits April 4, 2026 17:07

ACR Sdk distribution: Cleanup startupscriptgenerator and fix image re…

6e2c252

…po constants (#2867) * update logic for dotnet and default versions * Refactor ACR SDK provider to return tarball path * Cleanup startupscriptgen and refactor ACR SDK distribution constants

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: ACR-based SDK distribution with feature flag#2837

feat: ACR-based SDK distribution with feature flag#2837
CodingIsBliss wants to merge 37 commits intomainfrom
feature/oryx-sdk-acr-distribution

CodingIsBliss commented Apr 1, 2026 •

edited

Loading

Uh oh!

sarsharma commented Apr 2, 2026 •

edited

Loading

Uh oh!

sarsharma Apr 4, 2026

Uh oh!

sarsharma Apr 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

CodingIsBliss commented Apr 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Architecture

Fallback Chain

New Files (8)

Modified Files (27)

Feature Flag

Related PRs

Uh oh!

sarsharma commented Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sarsharma Apr 4, 2026

Choose a reason for hiding this comment

Uh oh!

sarsharma Apr 4, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

CodingIsBliss commented Apr 1, 2026 •

edited

Loading

sarsharma commented Apr 2, 2026 •

edited

Loading