Skip to content

Eagerly create multi-entry/fulltext index object stores in transaction constructor #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jell0wed wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Eagerly create multi-entry/fulltext index object stores in transaction constructor #84

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
209562b
Eagerly create multi-entry/fulltext index object stores in transactio…
Apr 28, 2026
503febe
prettier
Apr 28, 2026
4c1ed4b
fix prettier
Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 34 additions & 4 deletions src/IndexedDbProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -746,6 +746,7 @@ export class IndexedDbProvider extends DbProvider {
// DbTransaction implementation for the IndexedDB DbProvider.
export class IndexedDbTransaction implements DbTransaction {
private _stores: IDBObjectStore[];
private _indexStoreMap: Map<string, IDBObjectStore>;

constructor(
private _trans: IDBTransaction,
Expand All @@ -760,6 +761,28 @@ export class IndexedDbTransaction implements DbTransaction {
this._trans.objectStore(storeName)
);

// Eagerly capture multi-entry/fullText index object stores while the transaction is still
// in "active" state. Deferring this to getStore() risks an InvalidStateError if the event
// loop runs between openTransaction() and the first getStore() call, causing the IDB
// transaction to auto-commit before the objectStore() call.
this._indexStoreMap = new Map<string, IDBObjectStore>();
if (_fakeComplicatedKeys) {
each(this._transToken.storeNames, (storeName) => {
const storeSchema = find(_schema.stores, (s) => s.name === storeName);
if (storeSchema?.indexes) {
each(storeSchema.indexes, (indexSchema) => {
if (indexSchema.multiEntry || indexSchema.fullText) {
const indexStoreName = storeSchema.name + "_" + indexSchema.name;
this._indexStoreMap.set(
indexStoreName,
this._trans.objectStore(indexStoreName)
);
}
});
}
});
}

if (lockHelper) {
// Chromium seems to have a bug in their indexeddb implementation that lets it start a timeout
// while the app is in the middle of a commit (it does a two-phase commit). It can then finish
Expand Down Expand Up @@ -847,12 +870,19 @@ export class IndexedDbTransaction implements DbTransaction {

const indexStores: IDBObjectStore[] = [];
if (this._fakeComplicatedKeys && storeSchema.indexes) {
// Pull the alternate multientry stores in as well
// Pull the alternate multientry stores in as well, using the map populated eagerly in the
// constructor to avoid calling objectStore() after an async yield (which would throw
// InvalidStateError if the transaction has already auto-committed).
each(storeSchema.indexes, (indexSchema) => {
if (indexSchema.multiEntry || indexSchema.fullText) {
indexStores.push(
this._trans.objectStore(storeSchema.name + "_" + indexSchema.name)
);
const indexStoreName = storeSchema.name + "_" + indexSchema.name;
const indexStore = this._indexStoreMap.get(indexStoreName);
if (!indexStore) {
throw new Error(
"Index store not found in transaction: " + indexStoreName
);
}
indexStores.push(indexStore);
}
});
}
Expand Down
Loading