[python-package] add Literal type annotation for order variable in _np2d_to_np1d #7118
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p2d_to_np1d The order variable was inferred as str but numpy.asarray expects Literal['K', 'A', 'C', 'F']. Added explicit Literal["C", "F"] type annotation before the conditional assignment. This resolves the mypy call-overload error for np.asarray at line 201.
wagner-austin
requested review from
StrikerRUS,
borchero,
guolinke,
jameslamb,
jmoralez and
shiyu1994
as code owners
jameslamb
requested changes
Dec 30, 2025
| dtype = mat.dtype | ||
| else: | ||
| dtype = np.float32 | ||
| order: Literal["C", "F"] |
Collaborator
There was a problem hiding this comment.
Have you tried running lightgbm's tests locally?
I think this is going to fail because typing.Literal is not imported at runtime, only type-checking time:
LightGBM/python-package/lightgbm/basic.py
Lines 48 to 49 in 52dbf06
You'll need to either move that import up alongside the other runtime ones or change this to deferred evaluation like this:
order: "Literal['C', 'F']"Either is fine with me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add
Literaltype annotation forordervariable in_np2d_to_np1dfunction to fix mypycall-overloaderror withnp.asarray.Mypy Error (before fix)
Related Issue
Fixes: #3867
Test Plan
pre-commit run mypy --files python-package/lightgbm/basic.py