thread context for omp parallel to pass thread local allocator#644
Closed
ltan1ms wants to merge 2 commits intoBANN_save_load_one_filefrom
Closed
thread context for omp parallel to pass thread local allocator#644ltan1ms wants to merge 2 commits intoBANN_save_load_one_filefrom
ltan1ms wants to merge 2 commits intoBANN_save_load_one_filefrom
Conversation
amrmorsey
reviewed
Apr 9, 2025
Comment on lines
+1
to
+2
| #ifndef _THREAD_CONTEXT_H_ | ||
| #define _THREAD_CONTEXT_H_ |
There was a problem hiding this comment.
Will using #pragma once instead be better?
Contributor
Author
There was a problem hiding this comment.
good catch, will add.
| diskann::cout << "Starting final cleanup.." << std::flush; | ||
| } | ||
| #ifdef _ANN_ALLOCATOR | ||
| #pragma omp parallel for schedule(dynamic, 2048) firstprivate(context) |
There was a problem hiding this comment.
Should we also call OmpParallelContext context; here?
Contributor
Author
There was a problem hiding this comment.
it's defined by line 1573.
amrmorsey
approved these changes
Apr 10, 2025
Contributor
|
@ltan1ms feel free to merge into BANN branch. if not relevant anymore, please close PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
What does this implement/fix? Briefly explain your changes.
Any other comments?