Skip to content

Fix DS126858 false positive on --nomd5 and similar disable flags #722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 6 commits into
base: main
Choose a base branch
from
+13 −6
Open

Fix DS126858 false positive on --nomd5 and similar disable flags #722

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
94598a4
Initial plan
Copilot Feb 4, 2026
791e7a9
Fix DS126858 false positive for --nomd5 flag
Copilot Feb 4, 2026
d580086
Add word boundaries to negative lookbehind patterns
Copilot Feb 4, 2026
6a54c65
Revert .gitignore change for DevSkim-DotNet/nuget.config
Copilot Feb 12, 2026
c19e2a3
Add changelog entry for DS126858 false positive fix
Copilot Feb 12, 2026
d817188
Merge branch 'main' into copilot/fix-ds126858-flagging
gfs Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [1.0.76] - 2026-02-12
### Fix
- Fixed DS126858 rule (Weak/Broken Hash Algorithm) false positive when MD5 is explicitly disabled via flags like `--nomd5`, `nomd5`, `no-md5`, `no_md5`, or `disable_md5_check`

## [1.0.75] - 2026-02-06
### Changed
- Removed unnecessary uninstall/reinstall of @vscode/vsce from postinstall script in VSCode plugin
Expand Down
15 changes: 9 additions & 6 deletions rules/default/security/cryptography/hash_algorithm.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"rule_info": "DS126858.md",
"patterns": [
{
"pattern": "(MD2|MD4|MD5|RIPEMD|RIPEMD(128|256|160|320)|(SHA0|SHA-0|SHA1|SHA-1))",
"pattern": "(?<!\\bno)(?<!\\bno-)(?<!\\bno_)(?<!\\bdisable_)(MD2|MD4|MD5|RIPEMD|RIPEMD(128|256|160|320)|(SHA0|SHA-0|SHA1|SHA-1))",
"type": "regex",
"scopes": [
"code"
Expand All @@ -27,7 +27,7 @@
"type": "RegexReplace",
"replacement": "SHA256",
"pattern": {
"pattern": "(MD2|MD4|MD5|RIPEMD|RIPEMD(128|256|160|320)|(SHA0|SHA-0|SHA1|SHA-1))",
"pattern": "(?<!\\bno)(?<!\\bno-)(?<!\\bno_)(?<!\\bdisable_)(MD2|MD4|MD5|RIPEMD|RIPEMD(128|256|160|320)|(SHA0|SHA-0|SHA1|SHA-1))",
"type": "regex",
"scopes": [
"code"
Expand All @@ -40,7 +40,7 @@
"type": "RegexReplace",
"replacement": "SHA512",
"pattern": {
"pattern": "(MD2|MD4|MD5|RIPEMD|RIPEMD(128|256|160|320)|(SHA0|SHA-0|SHA1|SHA-1))",
"pattern": "(?<!\\bno)(?<!\\bno-)(?<!\\bno_)(?<!\\bdisable_)(MD2|MD4|MD5|RIPEMD|RIPEMD(128|256|160|320)|(SHA0|SHA-0|SHA1|SHA-1))",
"type": "regex",
"scopes": [
"code"
Expand All @@ -53,7 +53,7 @@
"type": "RegexReplace",
"replacement": "sha512",
"pattern": {
"pattern": "(md2|md4|md5|ripemd|ripemd(128|256|160|320)|(sha0|sha-0|sha1|sha-1))",
"pattern": "(?<!\\bno)(?<!\\bno-)(?<!\\bno_)(?<!\\bdisable_)(md2|md4|md5|ripemd|ripemd(128|256|160|320)|(sha0|sha-0|sha1|sha-1))",
"type": "regex",
"scopes": [
"code"
Expand All @@ -66,7 +66,7 @@
"type": "RegexReplace",
"replacement": "sha256",
"pattern": {
"pattern": "(md2|md4|md5|ripemd|ripemd(128|256|160|320)|(sha0|sha-0|sha1|sha-1))",
"pattern": "(?<!\\bno)(?<!\\bno-)(?<!\\bno_)(?<!\\bdisable_)(md2|md4|md5|ripemd|ripemd(128|256|160|320)|(sha0|sha-0|sha1|sha-1))",
"type": "regex",
"scopes": [
"code"
Expand All @@ -80,7 +80,10 @@
"echo -n Welcome | md5sum"
],
"must-not-match": [
"SHA512"
"SHA512",
"makeself --sha256 --nomd5",
"--nomd5",
"disable_md5_check"
]
},
{
Expand Down
Loading