Conversation
Contributor
There was a problem hiding this comment.
PR Summary
Updates infrastructure to support Python 3.13 by modifying CI workflows and dependency specifications.
- Modified
.github/workflows/test.yamlto replace Python 3.12 with 3.13 in initial test job and added 3.12 to secondary testing matrix - Updated
libs/infinity_emb/pyproject.tomlto remove numpy's upper bound constraint, enabling numpy 2.0 compatibility - Added conditional dependencies in
pyproject.tomlfor onnxruntime packages based on Python version - Introduced new Python 3.13-specific dependencies (pyarrow, scipy) while maintaining backward compatibility
2 files reviewed, no comments
Edit PR Review Bot Settings | Greptile
Owner
|
confused, is this outdated? |
|
Perhaps a separate PR just to upgrade Poetry v2.2.1 (or |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #594
Related Issue
Checklist
Additional Notes
Add any other context about the PR here.