Skip to content

Turn off Node's own localStorage in Vitest workers - #18

Draft
mgballou wants to merge 1 commit into
mainfrom
dm-vitest-under-node-26
Draft

mgballou wants to merge 1 commit into
mainfrom
dm-vitest-under-node-26

Conversation

@mgballou

Copy link
Copy Markdown
Owner
  • Passed --no-experimental-webstorage to Vitest fork workers in the root vitest.config.ts so jsdom's localStorage is not shadowed by Node 25+'s own
  • Fixes 110 failures across App.test.tsx, BuyRail.test.tsx, onboarding.test.ts, useSound.test.ts and useBuyQuantity.test.ts under Node 26; Node 22 accepts the flag and runs unchanged

@netlify

netlify Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for dreadmajesty ready!

Name Link
🔨 Latest commit 9dc8c17
🔍 Latest deploy log https://app.netlify.com/projects/dreadmajesty/deploys/6abaa74097daf400083e4e33
😎 Deploy Preview https://deploy-preview-18--dreadmajesty.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@mgballou

mgballou commented Oct 2, 2026

Copy link
Copy Markdown
Owner Author

Local verification: current and green

Main da92b00319bcbb46bfc074e9bb81a221f7c6c1b4 is already included; merging origin/main reported already up to date. Verified head: 9dc8c17ee1e17580c1db2b36a8f5955eba100e8d. HTTPS push reported everything up to date.

Used Node 26.7.0 and pnpm 11.18.0. Commands ran in an isolated worktree; PATH began with /opt/homebrew/bin. Every check/build had a 900-second timeout and used rtk proxy.

Command Exit Result
pnpm install --frozen-lockfile 0 Locked dependencies installed
pnpm check 0 Typecheck, lint, formatting; 63 files / 1371 tests passed
NODE_OPTIONS=--no-experimental-webstorage pnpm check 0 README #20 command; 63 files / 1371 tests passed
pnpm build 0 Production build succeeded; no tests in this command

This branch passes under Node 26 without requiring the environment flag. Draft state unchanged. No PR merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants