Add vpn-service #76
Open
Add vpn-service #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hajj88033-lang
approved these changes
Dec 14, 2025
Gerrit91
reviewed
Jan 12, 2026
proto/metalstack/admin/v2/vpn.proto
Outdated
| // VPNService serves vpn related functions | ||
| service VPNService { | ||
| // AuthKey generates a authkey for a project to join a machine to the project vpn | ||
| rpc Authkey(VPNServiceAuthkeyRequest) returns (VPNServiceAuthkeyResponse) { |
Contributor
There was a problem hiding this comment.
Suggested change
| rpc Authkey(VPNServiceAuthkeyRequest) returns (VPNServiceAuthkeyResponse) { | |
| rpc AuthKey(VPNServiceAuthkeyRequest) returns (VPNServiceAuthkeyResponse) { |
| } | ||
| // ListNodes returns a list of machines actually connected to the vpn | ||
| rpc ListNodes(VPNServiceListNodesRequest) returns (VPNServiceListNodesResponse) { | ||
| option (metalstack.api.v2.admin_roles) = ADMIN_ROLE_EDITOR; |
Contributor
There was a problem hiding this comment.
Suggested change
| option (metalstack.api.v2.admin_roles) = ADMIN_ROLE_EDITOR; | |
| option (metalstack.api.v2.admin_roles) = ADMIN_ROLE_EDITOR; | |
| option (metalstack.api.v2.admin_roles) = ADMIN_ROLE_VIEWER; |
proto/metalstack/admin/v2/vpn.proto
Outdated
| string address = 1; | ||
| // Authkey is the key to connect to the vpn at the given address. | ||
| // This key can only be seen once. | ||
| string authkey = 2; |
Contributor
There was a problem hiding this comment.
Suggested change
| string authkey = 2; | |
| string auth_key = 2; |
proto/metalstack/admin/v2/vpn.proto
Outdated
| // VPNServiceListNodesRequest is the request payload for a vpn list nodes request | ||
| message VPNServiceListNodesRequest { | ||
| // User if given only nodes of this user are returned | ||
| optional string user = 1; |
Contributor
There was a problem hiding this comment.
Maybe also use project and do not expose how headscale looks
proto/metalstack/api/v2/vpn.proto
Outdated
| // Name of this node | ||
| string name = 2; | ||
| // User of this node, maps to a project | ||
| optional string user = 3; |
Contributor
There was a problem hiding this comment.
Maybe project. Why can this be null?
Contributor
Author
There was a problem hiding this comment.
renamed, not optional anymore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add VPN related Service.