Skip to content

Fix logout dropdown item alignment - #3732

Open
oalders wants to merge 2 commits into
masterfrom
fix-3621
Open

oalders wants to merge 2 commits into
masterfrom
fix-3621

Conversation

@oalders

@oalders oalders commented Sep 18, 2026 •

Copy link
Copy Markdown
Member

Closes #3621 (final checklist item). Scope the .navbar-right button reset to :not(.dropdown-item) so the logout button matches its sibling dropdown items after the Bootstrap 5 upgrade.

🤖 Generated with Claude Code · Opus 4.8

Screenshot 2026-09-18 at 10 15 45 AM Screenshot 2026-09-18 at 10 15 58 AM

Scope the navbar-right button reset to :not(.dropdown-item) so the
logout button keeps normal .dropdown-item styling instead of the
icon-button reset.

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
@codecov

codecov Bot commented Sep 18, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.80%. Comparing base (884a610) to head (b11fe3b).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3732   +/-   ##
=======================================
  Coverage   76.80%   76.80%           
=======================================
  Files          71       71           
  Lines        2522     2522           
  Branches      360      360           
=======================================
  Hits         1937     1937           
  Misses        455      455           
  Partials      130      130           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
@oalders
oalders marked this pull request as ready for review September 18, 2026 14:16
@oalders
oalders requested review from haarg and a lite review from Copilot September 18, 2026 17:15
@oalders

oalders commented Sep 18, 2026

Copy link
Copy Markdown
Member Author

Oof. Clicked wrong thing and requested a co-pilot review. 😬

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The focused CSS changes correctly address the reported logout dropdown alignment issue.

Pull request overview

Scopes navbar button resets away from dropdown items so the logout button matches Bootstrap sibling items.

Changes:

  • Excludes .dropdown-item buttons from icon-button styling.
  • Adds hover underline styling to the logout dropdown button.
File summaries
File Description
root/static/scss/nav.scss Adjusts navbar and dropdown button styling.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Various issues with Bootstrap 5 update

2 participants