Repository navigation
Tidy imports: enable perlimports sort + blank-line-delimited blocks - #3730
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3730 +/- ##
=======================================
Coverage 76.80% 76.80%
=======================================
Files 71 71
Lines 2522 2522
Branches 360 360
=======================================
Hits 1937 1937
Misses 455 455
Partials 130 130
🚀 New features to boost your workflow:
|
haarg
reviewed
Sep 17, 2026
| use experimental 'postderef'; | ||
|
|
||
| use Moose; | ||
|
|
Member
There was a problem hiding this comment.
Moving use Moose after use experimental will re-enable the experimental warnings.
Hoist use Moo/Moose (and *::Role) into their own block above the contiguous includes, with a blank line above and below, and keep namespace::clean/autoclean in a trailing block. perlimports treats a blank line as a sort boundary, so this layout is stable under perlimports --sort instead of scattering the object-system pragma into the middle of the include list. Also move the PLACK_ENV TODO comment in app.psgi out of the import block (it had been dragged mid-block by --sort) to sit with the BEGIN env logic, keeping the imports contiguous. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Turn on the perlimports sort option so imports are kept alphabetically ordered. Paired with the blank-line-delimited import blocks so the object-system pragma (Moo/Moose) is not scattered into the include list. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
oalders
force-pushed
the
oalders-tidy-mc-web
branch
from
September 17, 2026 17:17
d8920df to
974b8f6
Compare
ranguard
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable
sortinperlimports.tomland reorganizeusestatements into blank-line-delimited blocks:use Moo/use Moose/*::Rolehoisted into their own block above the sorted includes.namespace::clean/autocleankept in a trailing block.Blank lines are sort boundaries for perlimports, so the object-system pragma stays put instead of being scattered mid-list. Changes are import reordering/whitespace only — no imports added or removed.
🤖 Generated with Claude Code