nRF52840 Power Management v2 Phase 1 - LPCOMP Wake and startup lockout #1413
+569
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added src/helpers/nrf52/Nrf52EarlyBoot.cpp: - Early register capture before SystemInit() Added src/helpers/nrf52/Nrf52PowerMgt.h: - Phase 1 API (PowerMgtConfig, PowerMgtState, initState, checkBootVoltage, configureLpcompWake, enterSystemOff) Added src/helpers/nrf52/Nrf52PowerMgt.cpp: - Initial Implementation Modified src/MeshCore.h: - Added power management virtual methods to MainBoard Added first supported board (Xiao nRF52840) for testing.
Author
|
Leaving this in a draft state so it can be tested as this is a major refactor to centralise more of the code away from individual variants, and tidy up general sloppiness/hacky code from the v1 implementation. |
Contributor
|
Would this work also e.g. with nfr52 based systems that do not have voltage divider resistors for the ADC port in place? (Thinking e.g. of ProMicro) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements initial stages of power management functionality for nRF52840 nodes to prevent lockups and flash corruption associated with low voltage. This is designed to be modular and enabled per-variant.
Phase 1 (this PR) includes: