fix(ske/ske-starterkit): wire stackit-ai secret into forgejo-connector e2e#216
Closed
malhussan wants to merge 1 commit into
Closed
fix(ske/ske-starterkit): wire stackit-ai secret into forgejo-connector e2e#216malhussan wants to merge 1 commit into
malhussan wants to merge 1 commit into
Conversation
…r e2e The e2e test referenced the ai-summarizer Helm chart which requires a 'stackit-ai' Kubernetes secret (STACKIT_AI_BASE_URL, STACKIT_AI_API_KEY, STACKIT_AI_MODEL), but the forgejo-connector module was never given additional_kubernetes_secrets to create it. The deploy job therefore failed with CreateContainerConfigError: secret "stackit-ai" not found. This gap existed since the e2e was first created (May 6). It was masked until June 26 by a bug in trigger_and_await_forgejo_workflow.py that declared success before the deploy job was even scheduled (281007c). Accept a stackit_ai_secret_data variable from the smoke-test runner and pass it to forgejo-connector as additional_kubernetes_secrets. The token is provisioned in meshstack-smoke-test/infra/stackit-ske via stackit_modelserving_token so the hub module stays environment-agnostic.
Contributor
Scorecard Check
📊 meshstack-hub Module Scorecard
📋 Per-Module Category SummaryScore per category per building block.
Core Structure — ✅ all passingBasic module file structure and documentation — applies to 1 modules
Core Structure — Summary
Integration — ✅ all passingmeshstack_integration.tf conventions — applies to 1 modules
Integration — Summary
Azure Backplane — not applicableAzure UAMI-based automation principal conventions — applies to 0 modules No applicable modules. STACKIT Backplane — not applicableSTACKIT WIF-based automation principal conventions — applies to 0 modules No applicable modules. Testing — some checks failingEnd-to-end test coverage — applies to 1 modules
Testing — Summary
|
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ai-summarizerHelm chart, which requires astackit-aiKubernetes secret (STACKIT_AI_BASE_URL,STACKIT_AI_API_KEY,STACKIT_AI_MODEL) viaenvFrom.secretRefadditional_kubernetes_secrets, so the secret was never created in the tenant namespaceCreateContainerConfigError: secret "stackit-ai" not foundtrigger_and_await_forgejo_workflow.pythat declared success before thedeployjob was scheduledstackit_ai_secret_datavariable from the smoke-test runner and pass it tomodule "forgejo_connector"asadditional_kubernetes_secrets; token provisioned inmeshstack-smoke-test/infra/stackit-ske