Skip to content

Feature/entra id groups#195

Merged
florianow merged 6 commits into
mainfrom
feature/entra-ID-groups
Jul 2, 2026
Merged

Feature/entra id groups#195
florianow merged 6 commits into
mainfrom
feature/entra-ID-groups

Conversation

@younGihan

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Scorecard Check

Scorecard run on commit c408a910ec53d35173a2cd8a11732da1d1bc01cc relative to origin/main

📊 meshstack-hub Module Scorecard

Generated: 2026-07-02 | Modules scanned: 1 | Categories: 5

📋 Per-Module Category Summary

Score per category per building block. n/a = category does not apply to this module.

Module Overall Core Structure Integration Azure Backplane STACKIT Backplane Testing
azure/entra-id-groups 🟢 93% 🟢 100% 🟢 100% 🟢 100% n/a 🔴 33%

⚠️ 1 module has failing checks — failing categories are expanded below.

Core Structure — ✅ all passing

Basic module file structure and documentation — applies to 1 modules

Module Score 📦 🔗 📋 📝 🖼️ 📌 🔒
azure/entra-id-groups 🟢 100%

Core Structure — Summary

Emoji Criterion Coverage Status
📦 buildingblock/ directory exists 1/1 🟢 100%
🔗 meshstack_integration.tf present 1/1 🟢 100%
📋 buildingblock/APP_TEAM_README.md present (no-integration fallback) n/a
📝 buildingblock/README.md with YAML front-matter 1/1 🟢 100%
🖼️ buildingblock/logo.png included 1/1 🟢 100%
📌 buildingblock/versions.tf present 1/1 🟢 100%
🔒 Provider versions use minimum constraint (>=) 1/1 🟢 100%
Integration — ✅ all passing

meshstack_integration.tf conventions — applies to 1 modules

Module Score 🏷️ 🏢 📤 🔌 📎 🔀 📋 🏷️ 📖 📝 📊 🚫 🔄
azure/entra-id-groups 🟢 100%

Integration — Summary

Emoji Criterion Coverage Status
🏷️ variable "hub" in integration 1/1 🟢 100%
🏢 variable "meshstack" in integration 1/1 🟢 100%
📤 building_block_definition output exposed 1/1 🟢 100%
🔌 meshcloud/meshstack in required_providers 1/1 🟢 100%
📎 backplane source uses var.hub.git_ref 1/1 🟢 100%
🔀 ref_name uses var.hub.git_ref 1/1 🟢 100%
📋 version_spec.draft uses var.hub.bbd_draft 1/1 🟢 100%
🏷️ BBD metadata.tags forwards var.meshstack.tags 1/1 🟢 100%
📖 BBD readme field present 1/1 🟢 100%
📝 BBD readme starts with plain-text description (no heading) 1/1 🟢 100%
📊 BBD readme has shared responsibility table (✅/❌) 1/1 🟢 100%
🚫 No documentation_md output in backplane 1/1 🟢 100%
🔄 meshstack_platform has lifecycle ignore_changes = [availability] n/a
Azure Backplane — ✅ all passing

Azure UAMI-based automation principal conventions — applies to 1 modules

Module Score 🪪 🚫 🚫 🔑 🔗 🧹 📤 📍
azure/entra-id-groups 🟢 100%

Azure Backplane — Summary

Emoji Criterion Coverage Status
🪪 Uses azurerm_user_assigned_identity 1/1 🟢 100%
🚫 No azuread_application resources 1/1 🟢 100%
🚫 No azuread_service_principal resources 1/1 🟢 100%
🔑 No azuread_application_password resources 1/1 🟢 100%
🔗 Uses azurerm_federated_identity_credential 1/1 🟢 100%
workload_identity_federation is non-nullable 1/1 🟢 100%
🧹 No create_service_principal_name toggle 1/1 🟢 100%
📤 Outputs identity (client_id, principal_id, tenant_id) 1/1 🟢 100%
📍 Integration has azure_location 1/1 🟢 100%
STACKIT Backplane — not applicable

STACKIT WIF-based automation principal conventions — applies to 0 modules

No applicable modules.

Testing — some checks failing

End-to-end test coverage — applies to 1 modules

Module Score ⚙️ 🧪
azure/entra-id-groups 🔴 33%

Testing — Summary

Emoji Criterion Coverage Status
⚙️ backplane/ directory (optional tier) 1/1 🟢 100%
🧪 e2e/ test directory exists 0/1 🔴 0%
e2e/ contains .tftest.hcl files 0/1 🔴 0%

@aws-amplify-eu-central-1

Copy link
Copy Markdown

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-195.d1o16zfeoh2slu.amplifyapp.com

@jannymeshi

jannymeshi commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

📋 This PR has been linked to the [Feature Shipping Tracker: Self-service Entra SSO (CU-86c7t51na)] (meshcloud/janny#736).

It addresses DoD item 6 (Reference Examples and Implementations Updated) — adding a hub reference example for Entra ID groups setup via the meshObject API.

@younGihan younGihan requested a review from grubmeshi June 9, 2026 09:04
Comment thread modules/azure/entra-id-groups/backplane/main.tf Outdated
Comment thread modules/azure/entra-id-groups/backplane/main.tf Outdated
Comment thread modules/azure/entra-id-groups/backplane/main.tf Outdated
Comment thread modules/azure/entra-id-groups/backplane/README.md Outdated
Comment thread modules/azure/entra-id-groups/backplane/README.md
Comment thread modules/azure/entra-id-groups/buildingblock/versions.tf Outdated
Comment thread modules/azure/entra-id-groups/meshstack_integration.tf
Comment thread modules/azure/entra-id-groups/meshstack_integration.tf Outdated
Comment thread modules/azure/entra-id-groups/meshstack_integration.tf Outdated
Comment thread modules/azure/entra-id-groups/meshstack_integration.tf Outdated
@florianow florianow force-pushed the feature/entra-ID-groups branch 2 times, most recently from fb05cca to 311da14 Compare June 19, 2026 14:07
chore: solve comments
@florianow florianow force-pushed the feature/entra-ID-groups branch from 311da14 to a492702 Compare July 2, 2026 08:54
@florianow florianow merged commit e23cc7a into main Jul 2, 2026
3 checks passed
@florianow florianow deleted the feature/entra-ID-groups branch July 2, 2026 08:59
@florianow florianow restored the feature/entra-ID-groups branch July 2, 2026 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants