Open
Conversation
Collaborator
|
It doesnt pass the build. most probably a formatting issue? |
Codecov Report
@@ Coverage Diff @@
## master #337 +/- ##
==========================================
- Coverage 91.89% 90.55% -1.35%
==========================================
Files 11 12 +1
Lines 1074 1133 +59
==========================================
+ Hits 987 1026 +39
- Misses 87 107 +20
Continue to review full report at Codecov.
|
Author
|
Any idea why this still isn't passing @cgestes ? I've removed the extra import line and added unit tests |
Collaborator
|
Formatting? |
Author
|
Yup, it was one erroneous line. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pretty much as stated, a converter for converting between notus and quill formats.