Remove highlightElevation from RawZefyrButton#103
Open
kolja-esders wants to merge 1 commit intomemspace:masterfrom
Open
Remove highlightElevation from RawZefyrButton#103kolja-esders wants to merge 1 commit intomemspace:masterfrom
kolja-esders wants to merge 1 commit intomemspace:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #103 +/- ##
=======================================
Coverage 92.11% 92.11%
=======================================
Files 12 12
Lines 1090 1090
=======================================
Hits 1004 1004
Misses 86 86Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Currently, there is a pretty intense elevation of active toolbar buttons during a long-press. The elevation is also visible for a short period of time when the user toggles an active button to become inactive.
This behavior does not look intended and does not seem coherent with the perception of a simple on/off toggle button (suddenly there is a third dimension out of nowhere).
Fix
The PR explicitly sets the
highlightElevationof the underlyingRawMaterialButtonto0.