fix(google): send tool schemas via parametersJsonSchema#18
Merged
sheepbox8646 merged 1 commit intoJun 17, 2026
Merged
Conversation
sheepbox8646
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
背景
关联 issue:memohai/Memoh#620
Memoh 在使用 Gemini tool calling 时会遇到 400 报错。原因是 Twilight AI 旧实现把
sdk.Tool.Parameters放到了 GeminifunctionDeclarations[].parameters。但 Gemini 的parameters是 Schema 子集,不支持完整 JSON Schema 字段,例如additionalProperties。当工具参数 schema 包含
additionalProperties: false时,Gemini 会返回:修改内容
parametersJsonSchema发送工具参数 schemaadditionalProperties: falseadditionalProperties的 tool schemaparametersparametersJsonSchemaadditionalProperties: false验证
已通过:
go test ./...go vet ./...golangci-lint run ./...go build ./...go test ./... -short -race -count=1go test ./provider/google/generativeai -run TestIntegration_ToolCallWithAdditionalPropertiesSchema -count=1 -v