Update registration endpoint to use db transaction to avoid integrity… - #340
Open
jabelone wants to merge 2 commits into
Open
Update registration endpoint to use db transaction to avoid integrity…#340jabelone wants to merge 2 commits into
jabelone wants to merge 2 commits into
Conversation
… issues also changed duplicate email error to generic error to mitigate against potential username/email enumeration attacks
|
Created image with name |
|
Created image with name |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug where the database gets into a broken state if the user model is created successfully but the profile one fails for some reason. Wraps both into a single database transaction to ensure integrity.