fix(package-build.el): Resolve all select coding system on Windows #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@tarsius Can you take a look at this? Thanks! 😅 |
Member
|
This seems reasonable to me, to ensure the generated files are consistently encoded. It might even be worth adding a local var into the generated file to make the coding system explicit. |
tarsius
pushed a commit
that referenced
this pull request
Jan 3, 2026
Member
|
Merged, thanks! (Github somehow did not notice so it is "closed" instead of "merged".) |
Contributor
Author
|
Thank you for merging this! 🥳 Happy New Year! (to both) |
Member
|
🎈 |
Member
|
Nice, thanks folks, and happy new year! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry, I wasn't very clear in my first PR #93. Let me try better this time. 😅
I've recently encountered more
Select coding system (default utf-8):prompts on Windows 11. 🤔 (The same as #70)This patch tries to cover all possible places that could cause this bug.
Log: https://github.com/emacs-tree-sitter/tree-sitter-langs/actions/runs/20451954046/job/58766656622?pr=1272#step:9:36