service-worker: await unnecessary, errors should be handled#254
Open
service-worker: await unnecessary, errors should be handled#254
Conversation
There was a problem hiding this comment.
The original function is intended to throw the exception to the outside where the function is called, whether its thrown exception should be handled or not completely decided by outside caller.
The fix make it outside caller unable to handle it any more.
Another issue is that the original function will end only when the put execution ends, but the fix make the outside caller unable to detect when function ends.
So I believe the fix is not correct and should be closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pretty simple stuff, minimal code changed.
awaitas the last command in a function is pointless. Errors thrown during the completion of a promise should be handled. Low probability of errors in this project as-is, but high probability of errors for any newbie adapting this example for their own project.The two calls to
caches.match()could use similar.catch()blocks, but I left them alone for now. They're easy enough to add before merging if you all decide to include them.