Keep IBM Plex search text inside its control - #4
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
🟢 Approval recommended
The changes are small, consistent with existing UI styling patterns (including prior overflow_hidden() usage), and align with the PR’s stated goal without introducing new risk.
Pull request overview
This PR updates the SearchInput UI to avoid text overflow issues by shortening the placeholder text and ensuring the search control clips any custom-painted text to its bounds.
Changes:
- Shortened the search placeholder string to better fit the field.
- Added
.overflow_hidden()to the search input container so painted text is clipped at the control boundary.
File summaries
| File | Description |
|---|---|
src/ui/text_input.rs |
Shortens search placeholder and clips search input rendering within its bounds via overflow_hidden(). |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 659c39aa55
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| .on_mouse_move(cx.listener(Self::mouse_move)) | ||
| .h(px(28.)) | ||
| .w_full() | ||
| .overflow_hidden() |
There was a problem hiding this comment.
When a query is wider than the 320 px toolbar field, this clips the shaped line, selection, and cursor, but SearchTextElement always paints from bounds.origin and has no horizontal offset or scroll state. Consequently, after typing or pasting a sufficiently long query, its tail and caret become invisible while edits continue there; retain the clipping but shift/scroll the rendered line so the active cursor remains within the field.
Useful? React with 👍 / 👎.
Summary
Verification