refactor(tests): resolve Windows compatibility issues in integration tests#445
Open
jafin wants to merge 1 commit intombrt:masterfrom
Open
refactor(tests): resolve Windows compatibility issues in integration tests#445jafin wants to merge 1 commit intombrt:masterfrom
jafin wants to merge 1 commit intombrt:masterfrom
Conversation
Contributor
jafin
commented
Feb 15, 2026
jafin
commented
- Use filepath.Dir instead of path.Dir for proper Windows path handling
- Add normalizeLineEndings helper for cross-platform line ending comparison
- Fix ReadFile path argument to avoid double testdata prefix
- Replace symlink with jsonnet import for Windows compatibility
- Use filepath.Dir instead of path.Dir for proper Windows path handling - Add normalizeLineEndings helper for cross-platform line ending comparison - Fix ReadFile path argument to avoid double testdata prefix - Replace symlink with jsonnet import for Windows compatibility
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #445 +/- ##
=======================================
Coverage 37.56% 37.56%
=======================================
Files 54 54
Lines 3663 3663
=======================================
Hits 1376 1376
Misses 2196 2196
Partials 91 91 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mbrt
requested changes
Feb 18, 2026
Owner
mbrt
left a comment
mbrt
left a comment
There was a problem hiding this comment.
Please use WSL for developing, as I don't have a good way to keep tests working on Windows.
| t.Run(name, func(t *testing.T) { | ||
| // Parse the config. | ||
| cfg, err := config.ReadFile(cfgPath, filepath.Join("testdata", cfgPath)) | ||
| cfg, err := config.ReadFile(cfgPath, cfgPath) |
Owner
There was a problem hiding this comment.
This makes the tests fail, it seems?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.