Skip to content

Fix circular JSON error in error handling and empty query in findRecords #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
neilwjsimpson wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix circular JSON error in error handling and empty query in findRecords #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dist/filemaker-mcp.d.ts.map
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

41 changes: 29 additions & 12 deletions dist/filemaker-mcp.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/filemaker-mcp.js.map
View file
Open in desktop

Large diffs are not rendered by default.

43 changes: 29 additions & 14 deletions src/filemaker-mcp.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1110,18 +1110,23 @@ export class FileMakerMCP {
fs.writeFileSync('/tmp/filemaker-error-handler.log', `Error handler called for tool ${name}`, 'utf8');

// DEBUG: Log the raw error to see its structure
// Note: error.response is an Axios response object with circular refs (ClientRequest <-> IncomingMessage)
// Only extract serializable parts to avoid "Converting circular structure to JSON" errors
const errorLog = {
timestamp: new Date().toISOString(),
toolName: name,
errorType: typeof error,
errorMessage: error.message,
errorResponse: error.response,
errorData: error.response?.data,
errorStatus: error.response?.status,
errorKeys: Object.keys(error)
errorKeys: error && typeof error === 'object' ? Object.keys(error) : []
};

fs.writeFileSync('/tmp/filemaker-error-debug.log', JSON.stringify(errorLog, null, 2), 'utf8');

try {
fs.writeFileSync('/tmp/filemaker-error-debug.log', JSON.stringify(errorLog, null, 2), 'utf8');
} catch (logError) {
fs.writeFileSync('/tmp/filemaker-error-debug.log', `Failed to serialize error: ${error.message}`, 'utf8');
}

// IMPROVED ERROR HANDLING: Capture both HTTP response and FileMaker error details
let errorDetails = {
Expand Down Expand Up @@ -1171,13 +1176,19 @@ export class FileMakerMCP {

async findRecords(args: any) {
const { layout, query = {}, limit = 100, offset = 1 } = args;
const findRequest = {
query: Object.keys(query).length > 0 ? [query] : [],
limit,
offset,
};
let response;

if (Object.keys(query).length > 0) {
// Use _find endpoint when a query is provided
const findRequest = { query: [query], limit, offset };
response = await this.client.post(`/layouts/${layout}/_find`, findRequest);
} else {
// Use GET records endpoint when no query — _find rejects empty query arrays
response = await this.client.get(`/layouts/${layout}/records`, {
params: { _limit: limit, _offset: offset }
});
}

const response = await this.client.post(`/layouts/${layout}/_find`, findRequest);
return {
content: [
{
Expand Down Expand Up @@ -1333,17 +1344,21 @@ export class FileMakerMCP {
};
} catch (error: any) {
// DEBUG: Write error details to file to see if this code is being executed
// Note: error.response is an Axios response object with circular refs — only extract serializable parts
const errorLog = {
timestamp: new Date().toISOString(),
errorType: typeof error,
errorMessage: error.message,
errorResponse: error.response,
errorData: error.response?.data,
errorStatus: error.response?.status,
errorKeys: Object.keys(error)
errorKeys: error && typeof error === 'object' ? Object.keys(error) : []
};

fs.writeFileSync('/tmp/filemaker-error-debug.log', JSON.stringify(errorLog, null, 2), 'utf8');

try {
fs.writeFileSync('/tmp/filemaker-error-debug.log', JSON.stringify(errorLog, null, 2), 'utf8');
} catch (logError) {
fs.writeFileSync('/tmp/filemaker-error-debug.log', `Failed to serialize error: ${error.message}`, 'utf8');
}

// Handle error directly in the tool method
let errorDetails = {
Expand Down