Spec User suspension & locking endpoints #2278
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per MSC4323. Signed-off-by: Kévin Commaille <[email protected]>
Signed-off-by: Kévin Commaille <[email protected]>
Signed-off-by: Kévin Commaille <[email protected]>
Signed-off-by: Kévin Commaille <[email protected]>
Signed-off-by: Kévin Commaille <[email protected]>
Signed-off-by: Kévin Commaille <[email protected]>
anoadragon453
requested changes
Dec 31, 2025
Member
anoadragon453
left a comment
anoadragon453
left a comment
There was a problem hiding this comment.
LGTM overall, thanks for doing this!
Just some small things below, along with a clarification question.
| @@ -0,0 +1 @@ | |||
| Add endpoints to lock and suspend server-local users for administrations and add the `m.account_management` capability, as per [MSC4323](https://github.com/matrix-org/matrix-spec-proposals/pull/4323). | |||
Member
There was a problem hiding this comment.
Suggested change
| Add endpoints to lock and suspend server-local users for administrations and add the `m.account_management` capability, as per [MSC4323](https://github.com/matrix-org/matrix-spec-proposals/pull/4323). | |
| Add administrator endpoints to lock and suspend server-local users and add the `m.account_management` capability, as per [MSC4323](https://github.com/matrix-org/matrix-spec-proposals/pull/4323). |
| for locking and unlocking accounts as a server implementation detail. | ||
| that can be reversed. | ||
|
|
||
| {{% added-in v="1.18" %}} To lock or unlock an account, the administrators |
Member
There was a problem hiding this comment.
Suggested change
| {{% added-in v="1.18" %}} To lock or unlock an account, the administrators | |
| {{% added-in v="1.18" %}} To lock or unlock an account, administrators |
| without risk of the client losing state from a logout. Suspensions are reversible, | ||
| like locks and unlike deactivations. | ||
|
|
||
| {{% added-in v="1.18" %}} To suspend or unsuspend an account, the administrators |
Member
There was a problem hiding this comment.
Suggested change
| {{% added-in v="1.18" %}} To suspend or unsuspend an account, the administrators | |
| {{% added-in v="1.18" %}} To suspend or unsuspend an account, administrators |
Comment on lines
+170
to
+171
| The requesting user is not a server administrator, or the target user is another | ||
| administrator. The errcode is `M_FORBIDDEN`. |
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per MSC4323.
Pull Request Checklist
Preview: https://pr2278--matrix-spec-previews.netlify.app