Fix issues #224 and #225: Parallel Documentation and add Unit Tests#283
Open
kshitij-maths wants to merge 4 commits intomathLab:masterfrom
Open
Fix issues #224 and #225: Parallel Documentation and add Unit Tests#283kshitij-maths wants to merge 4 commits intomathLab:masterfrom
kshitij-maths wants to merge 4 commits intomathLab:masterfrom
Conversation
062173f to
31ebcdc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves the issues found in the Parallel Reduced Order Model (ROM) module. It modernizes the
ezyrb.parallelimplementation to align with the current EZyRB (v1.3.3) API and introduces a dedicated unit test suite.Fixes and Improvements
1. API Synchronization (#224)
.parametersand.snapshotscalls withparameters_matrixandsnapshots_matrixto match the coreDatabasestructure.fit()andpredict()methods. This ensures that data is passed to the POD and RBF engines in the correctscaler_red,database) from internal method calls that were causingTypeErrorduring parallel task distribution.2. Documentation & Quality (#225)
predict()methodDelaunayimports fromscipy.spatial.qhulltoscipy.spatialto maintain compatibility with SciPy 2.0.tests/test_parallel.pywhich covers:test_initialization: Verifies proper object construction and attribute mapping.test_fit: Confirms the parallel training workflow and generation of reduction modes.test_predict_scalar: Tests the "Transpose Sandwich" logic for a single parametric input.test_predict_db: Mathematically verifies accuracy by predicting a full database and comparing against original snapshots.test_wrong_dimensions: Ensures the model correctly raises exceptions for mismatched input data.Verification Results
pytest -v tests/test_parallel.pyRelated Issues
This PR resolves issues #224 and #225