-
Notifications
You must be signed in to change notification settings - Fork 51
Lazy loading #1044
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Lazy loading #1044
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1044 +/- ##
==========================================
- Coverage 77.33% 74.64% -2.70%
==========================================
Files 56 56
Lines 3036 2903 -133
==========================================
- Hits 2348 2167 -181
- Misses 688 736 +48 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
Just to note that these changes are effective: the tests run in roughly 140-160 sec, brought down from 200-210 sec on main |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancements:
Expanding scope of lazy loading to:
Some usage examples for the
LazyImportclass intests/core/test_utils.pyfor how it can be used beyond just the restersHousekeeping:
Focusing on removing (i) boilerplate repeated code and (ii) extraneous dependencies
msgpacksmart_openin favor of basicboto/gzipinteractionsemmet_query_open_datato throw uniform errors when objects cannot be found