solution#2236
Open
andriy-stetsula wants to merge 7 commits into
Open
Conversation
dothearts
suggested changes
Jun 1, 2026
dothearts
left a comment
dothearts
left a comment
There was a problem hiding this comment.
Please provide DEMO LINK.
- PR description
- README.md
Also, check the comments and fix them.
Many thanks!
| getTodos() | ||
| .then(data => setTodo(data)) | ||
| .catch(() => setError(LOAD_ERROR.LOAD_TODOS)); | ||
| }, []); |
There was a problem hiding this comment.
You can add linter ignore for this line
| }, [error]); | ||
|
|
||
| const filterTodo = todo.filter(todos => { | ||
| if (selected === 'active') { |
| } | ||
| }, [error]); | ||
|
|
||
| const filterTodo = todo.filter(todos => { |
There was a problem hiding this comment.
You can create a pure function and move it to a separate file (helpers.ts for example)
| setTitle(''); | ||
| }) | ||
|
|
||
| .catch(() => setError('Unable to add a todo')) |
There was a problem hiding this comment.
You have ENUM for this, move error in there and use in this place.
Author
added 3 commits
June 2, 2026 17:19
dothearts
suggested changes
Jun 2, 2026
dothearts
left a comment
dothearts
left a comment
There was a problem hiding this comment.
Please fix some minority comments.
Many thanks!
| setLoadingIds(prev => [...prev, id]); | ||
| deleteTodo(id) | ||
| .then(() => setTodo(prev => prev.filter(t => t.id !== id))) | ||
| .catch(() => setError('Unable to delete a todo')) |
| ) | ||
| .catch(() => setError('Unable to update a todo')) | ||
| .finally(() => { | ||
| setLoadingIds(prev => prev.filter(Ids => Ids !== currentTodo.id)); |
There was a problem hiding this comment.
Why Ids not ids?
As i see you don't need capitalize in this case.
| const handleDelete = (id: number) => { | ||
| setLoadingIds(prev => [...prev, id]); | ||
| deleteTodo(id) | ||
| .then(() => setTodo(prev => prev.filter(t => t.id !== id))) |
There was a problem hiding this comment.
fix all one letter notation in callbacks.
dothearts
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.