Configure ESLint, Prettier and Husky#88
Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
The implementation successfully meets the core requirements: ESLint is configured using the flat config format with the Playwright plugin integration, all Page Object classes follow correct patterns, and the Playwright tests are well-structured with proper selectors and assertions. The ESLint configuration placement concern noted for src/pages/SignUpPage.js appears to be a misattributed comment, as Page Object files don't contain ESLint configuration. The actual eslint.config.mjs file was reviewed separately and confirmed to have the eslint-config-prettier correctly integrated. The test files demonstrate solid Playwright practices with appropriate use of page objects, faker for dynamic test data, and complete test flows for both positive and negative scenarios. Your implementation is ready for use.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
| this.emailField = page.getByPlaceholder('Email'); | ||
| this.passwordField = page.getByPlaceholder('Password'); | ||
| this.signUpButton = page.getByRole('button', { name: 'Sign up' }); | ||
| this.errorMessage = page.getByRole('list').nth(1); |
There was a problem hiding this comment.
The eslint-config-prettier is placed at index 1 (line 10), before the rules object where other ESLint rules are defined. For ESLint's flat config, eslint-config-prettier should be placed LAST in the exports array to properly disable all formatting rules that conflict with Prettier. Consider moving it to the end of the array.
2 participants
Set Up Automatic Code Checks for a Conduit Project