set up eslint, prettier and husky#86
Conversation
|
eslint, prettier and husky were set up |
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Your ESLint configuration (eslint.config.mjs) is correctly set up using the modern flat config format, and your test files follow proper Playwright syntax. However, three critical components are missing from your submission that are explicitly required by the task:
- Prettier configuration - No
.prettierrc,prettier.config.mjs, or equivalent configuration file is present - Husky setup - The
.husky/pre-commithook file is missing (or the.huskydirectory itself) - Lint-Staged configuration - No
lint-stagedconfiguration is visible in yourpackage.jsonor as a separate config file
The file comments on your test files specifically state these are required per the task requirements. Please add the missing configuration files and ensure Prettier, Husky, and Lint-Staged are properly integrated with your commit workflow. Once added, your solution should meet all the checklist requirements.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
| @@ -1,32 +1,32 @@ | |||
| import { test } from "@playwright/test"; | |||
| import { SignInPage } from "../../src/pages/SignInPage"; | |||
| import { test } from '@playwright/test'; | |||
There was a problem hiding this comment.
Prettier configuration file is missing. According to the task requirements, Prettier needs to be set up using instructions from the theory section.
There was a problem hiding this comment.
The files are included in this PR. You can see .husky/pre-commit and .prettierrc in the Files changed tab. @mateacademy-ai-mentor
| @@ -1,32 +1,32 @@ | |||
| import { test } from "@playwright/test"; | |||
| import { SignInPage } from "../../src/pages/SignInPage"; | |||
| import { test } from '@playwright/test'; | |||
There was a problem hiding this comment.
Husky configuration files (e.g., .husky directory with pre-commit hook) are missing. According to the task requirements, Husky needs to be set up using instructions from the theory section.
There was a problem hiding this comment.
The files are included in this PR. You can see .husky/pre-commit and .prettierrc in the Files changed tab. @mateacademy-ai-mentor
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Sorry, the pull request review was unsuccessful for the following reasons:
Warning
No changes were made in the pull request since the last review. Please make sure that you have added files to the pull request and committed the changes.
[CODE: NCM]
If the issue is within your control, please address it.
The next review attempt will automatically launch in about 1 hour.
If you believe this is an error or need assistance, please contact the support team.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Sorry, the pull request review was unsuccessful for the following reasons:
Warning
No changes were made in the pull request since the last review. Please make sure that you have added files to the pull request and committed the changes.
[CODE: NCM]
If the issue is within your control, please address it.
The next review attempt will automatically launch in about 1 hour.
If you believe this is an error or need assistance, please contact the support team.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Sorry, the pull request review was unsuccessful for the following reasons:
Warning
No changes were made in the pull request since the last review. Please make sure that you have added files to the pull request and committed the changes.
[CODE: NCM]
If the issue is within your control, please address it.
The next review attempt will automatically launch in about 1 hour.
If you believe this is an error or need assistance, please contact the support team.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Sorry, the pull request review was unsuccessful for the following reasons:
Warning
No changes were made in the pull request since the last review. Please make sure that you have added files to the pull request and committed the changes.
[CODE: NCM]
If the issue is within your control, please address it.
The next review attempt will automatically launch in about 1 hour.
If you believe this is an error or need assistance, please contact the support team.
|
|
||
| async assertYourFeedTabIsVisible() { | ||
| await expect(this.yourFeedTab).toBeVisible(); | ||
| await expect(this.yourFeedTab).toBeVisible({ timeout: 10000 }); |
There was a problem hiding this comment.
is it required? better to set up one value in config
There was a problem hiding this comment.
better do not commit package-lock files
3 participants
No description provided.