Develop#403
Open
bagirovoleg wants to merge 37 commits into
Open
Conversation
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
danon321
suggested changes
Sep 26, 2025
danon321
left a comment
danon321
left a comment
There was a problem hiding this comment.
Tutaj kolor linków sie nie zgadza
Ten obrazek wyjezdza poza ekran przez co mamy dolny skrol. Trzeba sie pozbyc tego skrola
natalia-klonowska
suggested changes
Sep 26, 2025
natalia-klonowska
left a comment
natalia-klonowska
left a comment
There was a problem hiding this comment.
- shop title should be centered on mobile version
- image should stretch to the edges of the page on mobile version
- links should be different color
- underline on hover is fine but active link should also have a permanent underline to indicate navigation between tabs
- shop should display different products when switching between tabs. you can create your own examples since design only shows 2 products for "Face" tab and 1 for "Hair" tab
Did you implement product card view from design? It would be intuitive to show product card page when clicking on a product image/title
…b-based product switching, and product card view on click
danon321
approved these changes
Sep 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bagirovoleg.github.io/Eco_cosmetics/