fix(consensus): split process fn and replace panics with error handling#4963
Open
raushan728 wants to merge 1 commit intomassalabs:mainfrom
Open
fix(consensus): split process fn and replace panics with error handling#4963raushan728 wants to merge 1 commit intomassalabs:mainfrom
raushan728 wants to merge 1 commit intomassalabs:mainfrom
Conversation
raushan728
force-pushed
the
refactor/consensus-cleanup-and-stability
branch
from
f4f9d06 to
47c3df9
Compare
raushan728
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split the oversized
ConsensusState::processinto focused helper methodsand replaced
panic!/.expect()calls withResultpropagation anderror logging to prevent worker crashes.