Fix add_query_params dropping port and userinfo from URLs#50
Merged
eaguad1337 merged 1 commit intoJun 12, 2026
Merged
Conversation
add_query_params rebuilt the base URL from urlsplit().hostname, which excludes the port and any userinfo. As a result a redirect to e.g. http://127.0.0.1:9000/... came back as http://127.0.0.1/..., breaking links to hosts on non-default ports (e.g. presigned S3/MinIO URLs passed through Response.redirect()). Use .netloc instead, which preserves host, port and userinfo. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
masonite.utils.str.add_query_paramsrebuilds the base URL fromurlsplit(url).hostname, which excludes the port and any userinfo. So any URL with a non-default port loses it:Because
Response.redirect(location=...)passes the location throughadd_query_params, redirecting to a URL on a non-default port produces a brokenLocationheader. I hit this redirecting to a presigned S3/MinIO URL (http://host:9000/...?X-Amz-Signature=...): the port was stripped, so the browser hit port 80 and the download failed.Fix
Use
urlsplit(url).netlocinstead of.hostname.netlocpreserves host, port, and userinfo —hostnamedrops the port and userinfo. One line insrc/masonite/utils/str.py.Tests
Added to
tests/core/utils/test_str.py:add_query_params(url, {})Existing
add_query_paramstest expectations are unaffected (verified).