Address clang++20 nag about 'whitespace in literal operator'#263
Merged
marzer merged 1 commit intomarzer:masterfrom Mar 12, 2025
Merged
Address clang++20 nag about 'whitespace in literal operator'#263marzer merged 1 commit intomarzer:masterfrom
marzer merged 1 commit intomarzer:masterfrom
Conversation
Owner
|
Thanks 🎉 |
This was referenced Mar 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #261,
clang++-20now nags about a whitespace after the"""inoperator"". A simple and sufficient change is to remove the whitespace. I have done so inRcppTOMand the CRAN repository for R which is already running some checks withclang++-20no longer tags the package.I carried the same change over here.
Note that the embedded
catchandnlohmann::jsonhave the same issue inoperator ""(the initial whitespace betweenoperatorand""is apparently permitted) in a handful of places but as this is only used for testing I left it alone.Pre-merge checklist
origin/master(if necessary)