Skip to content

[WIP] Fix error message display when no translation is available - #1036

Open
jpetitcolas wants to merge 1 commit into
masterfrom
delete_error
Open

[WIP] Fix error message display when no translation is available#1036
jpetitcolas wants to merge 1 commit into
masterfrom
delete_error

Conversation

@jpetitcolas

Copy link
Copy Markdown
Contributor

Fixes on:

  • Creation
  • Edit
  • Delete
  • Batch delete
  • List
  • Show

@orgito

orgito commented May 5, 2016

Copy link
Copy Markdown

What is the purpose of that line?

const errorMessage = this.config.getErrorMessageFor(this.view, error) || 'ERROR_MESSAGE';

In what situation will getErrorMessageFor return a translationId?

@fedotxxl

fedotxxl commented Jun 8, 2016

Copy link
Copy Markdown
Contributor

when are you going to close it? Isn't it urgent?

@RichardBradley

Copy link
Copy Markdown
Contributor

My PR #1130 might fix some or all of this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants