fix(remappings): use lockfile install paths - #372
Open
mario-eth wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates remapping generation to prefer dependency install directories derived from soldeer.lock, making remappings deterministic when multiple installed versions satisfy a version requirement.
Changes:
- Use
soldeer.lockentries to compute a dependency’s install path when available. - Add a unit test to verify that the locked version is preferred over other matching installed versions.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+365
to
+372
| let locked_path = read_lockfile(&paths.lock).ok().and_then(|lockfile| { | ||
| lockfile.entries.into_iter().find(|entry| entry.name() == dependency.name()) | ||
| }); | ||
| let path = locked_path | ||
| .map(|entry| entry.install_path(&paths.dependencies)) | ||
| .or_else(|| dependency.install_path_sync(&paths.dependencies)) | ||
| .ok_or(RemappingsError::DependencyNotFound(dependency.to_string()))?; | ||
| let path = dunce::canonicalize(path)?; |
| .install_path_sync(&paths.dependencies) | ||
| .ok_or(RemappingsError::DependencyNotFound(dependency.to_string()))?, | ||
| )?; | ||
| let locked_path = read_lockfile(&paths.lock).ok().and_then(|lockfile| { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.