fix(install): error on conflicting dependency directory names - #366
Open
mario-eth wants to merge 1 commit into
Open
fix(install): error on conflicting dependency directory names#366mario-eth wants to merge 1 commit into
mario-eth wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds an early validation step to prevent installing/updating multiple dependencies that would map to the same on-disk directory name after filename sanitization, returning a clear error instead of proceeding into potentially conflicting filesystem operations.
Changes:
- Add a shared
validate_dependency_path_collisionsguard and invoke it at the start of install/update flows. - Introduce a new
InstallError::PathCollisionerror variant with a descriptive message. - Add a regression test covering a sanitized-name collision case (
foo/barvsfoo-bar).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| crates/core/src/update.rs | Runs the new collision validation before spawning update tasks. |
| crates/core/src/install.rs | Implements collision validation and invokes it in parallel and sequential install entrypoints; adds a regression test. |
| crates/core/src/errors.rs | Adds a new InstallError::PathCollision variant used by the validation. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
beeb
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.