fix: honor cache directives for streaming requests - #155
Open
peterpme wants to merge 1 commit into
Open
Conversation
|
@peterpme is attempting to deploy a commit to the Margelo Team on Vercel. A member of the Team first needs to authorize it. |
Collaborator
|
The tests seems to be failing . Lets fix that |
riteshshukla04
requested changes
Aug 3, 2026
| function applyCacheHeaders( | ||
| headers: NitroHeader[], | ||
| cache: RequestCache | undefined | ||
| ): void { |
Collaborator
There was a problem hiding this comment.
Can we add. worklets
| headers.push({ key: 'Cache-Control', value: 'no-cache' }); | ||
| headers.push({ key: 'Pragma', value: 'no-cache' }); | ||
| } | ||
| applyCacheHeaders(headers, cacheOption); |
Collaborator
There was a problem hiding this comment.
Maybe we can also wire buildNitroRequestPure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RequestInit.cacheheader mapping for standard and streaming fetchescache: "no-store"withstream: trueWhy
The standard path sends
Cache-Control: no-store, but the streaming path silently ignored the same option. On iOS, streaming uses a disk-backedURLCache, so authenticated streamed responses could remain eligible for persistence despite the caller explicitly requestingno-store.This keeps the existing cache enabled for default requests; it only honors the caller-selected directive.
Closes #154
Validation
bun lint(passes with two existing no-shadow warnings)bun typecheckbun test --maxWorkers=2