feat: Larger, configurable viewer UI text size (IMA-179) - #6
Merged
Conversation
Slider-row labels 12px -> 14px and superqt SliderLabel value text 10px -> 12px, driven by two module constants (UI_FONT_SIZE_PX, SLIDER_VALUE_FONT_SIZE_PX) interpolated into NDV_SLIDER_STYLE and the launcher drop-label style — one place to retune. Also replaces the T/FOV labels' setFixedWidth(30), which clipped text like "FOV: cell_0_0:3" and would clip more at the larger size, with _sync_slider_label_widths(): a shared width measured via an explicit QFont at UI_FONT_SIZE_PX (widget fontMetrics() are stale before polish), covering every known FOV label plus the slider maxima, and re-synced from the push-API label-set paths and slider rangeChanged. ndv's embedded controls keep their own font stylesheets (they beat any ancestor rule) — tracked separately as IMA-197. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…-larger-text # Conflicts: # ndviewer_light/core.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SliderLabelvalue text 10px → 12px, driven by two module constants (UI_FONT_SIZE_PX,SLIDER_VALUE_FONT_SIZE_PX) interpolated intoNDV_SLIDER_STYLEand the launcher drop-label style — configurable in one place (IMA-179 acceptance).setFixedWidth(30)with_sync_slider_label_widths()— shared width from explicit-QFont metrics (widgetfontMetrics()is stale before polish) over every known FOV label + slider maxima, re-synced from the push-API label-set paths andrangeChanged.__init__and the Squid shim.Test plan
tests/test_ui_font_size.py(8 tests): constant wiring, groove/handle regression guard, width fits widest FOV label, equal label widths, post-setup push-API resync, floor width. No ndv import.test_push_api.pyfailures reproduce on cleanmain(missingtifffilein local env, unrelated).🤖 Generated with Claude Code