Open
Conversation
Add logic from mapswipe/python-mapswipe-workers@dev...panoramax and refactor StreetImageProvider. This introduces a type change of View Streets project tasks taskId that requires migration and changes in Firebase.
…nsure correct sorting, sampling threshhold input in m instead km
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #236 +/- ##
===========================================
+ Coverage 87.41% 87.53% +0.11%
===========================================
Files 205 206 +1
Lines 12458 12529 +71
Branches 1049 1056 +7
===========================================
+ Hits 10890 10967 +77
+ Misses 1181 1177 -4
+ Partials 387 385 -2 ☔ View full report in Codecov by Sentry. |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on
Changes
This enables the MapSwipe backend to handle View Streets projects with different image providers (currently Mapillary and Panoramax).
This PR doesn't introduce any:
printThis PR contains valid: