-
-
Notifications
You must be signed in to change notification settings - Fork 968
Drag globe near poles with versor #5330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5330 +/- ##
==========================================
- Coverage 91.96% 91.88% -0.08%
==========================================
Files 282 282
Lines 39050 39099 +49
Branches 6855 6864 +9
==========================================
+ Hits 35911 35927 +16
- Misses 3012 3044 +32
- Partials 127 128 +1 ☔ View full report in Codecov by Sentry. |
| get pixelsToClipSpaceMatrix(): mat4 { | ||
| return this._helper.pixelsToClipSpaceMatrix; | ||
| } | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better to avoid these kind of changes as part of this PR, I would recommend moving this to a different PR if this is truly needed.
|
I played around with this for a while, here are some thoughts on the controls:
It works quite nicely overall! |
|
Looking forward to this! |
|
@jcolot any updates on this? |
|
@HarelM Sorry for this unfinished PR. If it's ok, I will try to work on it this month. From what I remember from when I stopped working on it is that it would maybe be nice to have two options for dragging: The classic one, and the one I introduce with versor calculations. What still needed to be done was fixing the easing, which should not be the same when using versor, and add tests. Happy to discuss. |
Launch Checklist
For points that are not on the globe, do nothing.
CHANGELOG.mdunder the## mainsection.