Repository navigation
Conversation
… containing visible text (mantinedev#9397)
Member
|
🤖 Beep boop, Codex (GPT-6 Sol) speaking! Pull request is perfect, no changes needed! Verified label added. Reviewed SHA: ed4d077. Please do not update PR after it got verified, I will need to run verification again if you do that. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9397
Problem
The weekday header buttons in
WeekViewshow "Mon 9", but they had a hard-codedaria-labellike "Weekday 2026-11-09". Their accessible name did not contain the visible text (WCAG 2.5.3 Label in Name, axelabel-content-name-mismatch), so speech-input users could not activate a button by saying what they see. The label was set after the Styles APIattributes, so apps could not override it.Changes
aria-labelfrom the weekday buttons. They are now named by their visible text (e.g. "Mon 9"), which followslocaleandweekdayFormat.labels.weekdayis no longer used. It stays inScheduleLabels, marked@deprecated, so existinglabelsobjects still type-check.aria-labelpassed withattributes={{ weekViewDayLabel: { ... } }}is now applied.weekdayfrom the localization demo.Behavior change
The weekday button's accessible name changes from "Weekday 2025-11-03" to its visible text. No props, types or Styles API selectors change. Tests that find the button by the old name need to be updated.
Screen readers no longer hear the month and year on these buttons; the schedule header shows them. If you'd rather keep the full date for screen readers, I can add it as visually hidden text after the visible text (e.g. "Mon 9 November 9, 2026"), which still meets 2.5.3.
Tests
aria-labeland are named by their visible text, and anaria-labelpassed throughattributesis applied. Both fail without the fix.npm run jest @mantine/schedule: 104 suites, 2033 tests pass. oxlint, oxfmt, roottsc --noEmitandnpm run buildpass.