Fix D1 release import and Windows tooling#53
Draft
mandel59 wants to merge 11 commits into
Draft
Conversation
Allow D1 import preparation to discover Unihan variant source relations from tables or views, and add a regression test that keeps the unihan_variant materialization SQL present for kTraditionalVariant imports. Related: #48 Generated-by: Codex/GPT-5.4
Include table and view backed unihan_k* relations when creating the D1 unihan table so space-delimited Unihan properties are not dropped from remote detail responses. Related: #48 Generated-by: Codex/GPT-5.4
Use fileURLToPath and avoid spawning .cmd shims directly from Node on Windows. Also decode Unihan variant codepoints with D1 char(codepoint) so variant search values are stored as valid Unicode characters. Related: #48 Generated-by: Codex/GPT-5.4
Point the default D1 Worker binding at the verified mojidata release database while keeping the existing idsfind database active. Related: #48 Generated-by: Codex/GPT-5.4
Detect idsfind.db with either POSIX or Windows path separators so D1 import uses the FTS5-safe SQL builder instead of raw SQLite dump output. Add coverage for Windows-style paths. Generated-by: Codex (GPT-5)
Add --binding selection to D1 release creation, import, and promotion. Release manifests now record selected and unchanged bindings, imports default to manifest-selected bindings, and promotion applies stale checks only to selected bindings. Document the per-DB workflow. Generated-by: Codex (GPT-5)
Generate blue/green release database names from binding-specific base names instead of appending release labels to the currently active database name. Document the naming rule and enforce a generated name length guard. Generated-by: Codex (GPT-5)
Add LF checkout rules for package shell scripts and download manifests, and document the Node 22 recommendation for Windows D1 release/import work. Generated-by: Codex (GPT-5)
Convert the idsdb-fts5 prepare output directory with cygpath when available so Windows Node receives a native path instead of a POSIX-style Git Bash path. Document the behavior in the D1 deployment notes. Generated-by: Codex (GPT-5)
The D1 deployment and release tooling changes do not publish package artifacts, so add an empty changeset for the pull request validation workflow. Generated-by: Codex (GPT-5)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MOJIDATA_DBreleaseidsfind.dbdetection so FTS5 import uses the D1-safe SQL builderidsdb-fts5output paths under Git BashVerification
corepack yarn mojidata-api:d1:checkcorepack yarn --cwd packages/idsdb-fts5 prepareunihan.kTraditionalVariant=線returnsresults=["线","缐"],total=2Related issues
unihan_variantが空で variant 系検索が0件になる #48 is already resolved in production