Repository navigation
test(remote-agent): groupRelay 用例清理临时目录时重试,避免与后台写入竞态 #5776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
FicoHub
wants to merge
4
commits into
makecindy:main
Choose a base branch
from
FicoHub:fix/group-relay-test-cleanup
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
beff558
test(remote-agent): groupRelay 用例清理临时目录时重试,避免与后台写入竞态
FicoHub c6f9aaa
test(remote-agent): groupRelay 用例异步清理并等待目录不再被重建
FicoHub edf3131
test(remote-agent): groupRelay 清理在删除失败时继续重试,并要求连续两个静默窗口
FicoHub 58b0c48
Merge origin/main into fix/group-relay-test-cleanup
FicoHub File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
在高负载 CI 让 guest-index I/O 超过 100 ms 时,这里仍能在两个 50 ms 采样后返回:
runHost.ts的startRelay()会先发布started、再等待recordGuestSession(),而 open 路径又以void ...then(startRelay)启动它,因此测试和client.close()都可能先完成,后台链随后仍会重建root。相较已有评论检查的版本,最终 diff 的新证据是退出条件虽然改成了absentChecks < 2,却仍完全不观察 host/promise 生命周期;hook 成功后泄漏的目录会在下一次beforeEach覆盖root后失去清理机会。请先 await host 的 flush/异步 dispose,再执行最终删除。AGENTS.md reference: AGENTS.md:L40-L41
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
同意:只要清理不观察 host 的 promise 生命周期,它就仍是启发式的;你举的
startRelay()先发布started、再等recordGuestSession()的路径也属实。这和 PRRT_kwDOTgdRUs6rJizN 是同一个取舍,我不再继续往测试侧叠等待逻辑:
runHost.ts里给后台链路(startRelay/recordGuestSession、影子工作区与附件目录的写入、disposeRun等)建立统一跟踪,并暴露whenIdle()或异步dispose();在此之前这条线程保持 open。
另:本 head(edf31311a)的 Linux/Windows (2/2) 失败是
remoteAgentRelocationWiring.test.ts「改道的行带上所属电脑」。main 自 7b07864 起同样失败(main client-ci 38107453839),与本 PR 无关;修复在 #5781。