Pynest

[mryel00]

No description provided.

[Copilot]

Pull request overview

Copilot reviewed 41 out of 46 changed files in this pull request and generated 25 comments.

Comments suppressed due to low confidence (2)

libs/helper_fn.sh:83

• The function 'run_apt_update' is now duplicated in both 'libs/helper_fn.sh' and 'tools/libs/helper_fn.sh'. This creates code duplication and maintenance issues. Consider consolidating these helper functions into a single location.

    [[ "$(is_pi5)" = "0" ]]; then
        echo "1"
    else

pylibs/v4l2/ctl.py:172

• Call to function get_control_cur_value_with_qc with too many arguments; should be no more than 2.

    return get_control_cur_value_with_qc(device_path, qc, control)

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Variable v4l2ctl is used before being checked for truthiness. If v4l2ctl is an empty string, it will be falsy in the if statement on line 69, but then on line 90 it's split unconditionally. This could result in attempting to split a falsy value that wasn't set. Consider ensuring v4l2ctl is properly initialized or checking it again before line 90.

Suggested change

	if v4l2ctl:
	if isinstance(v4l2ctl, str) and v4l2ctl.strip():

[Copilot]

Function 'install_runtime_env' is called but is never defined in this file. It should likely be 'setup_runtime_env' based on the function defined on line 153.

[Copilot]

Trailing comma on the last item of the JSON array. While this is valid in some JSON parsers, it's not standard JSON and may cause parsing errors in strict JSON parsers. Remove the trailing comma after the last array element.

[Copilot]

Function signature has incorrect parameter count. The function is defined with two parameters (device_path and qc) but the docstring and the calling code suggest it should only take one parameter (qc). The 'control' parameter mentioned in line 172 is not defined in the function signature.

[Copilot]

Using the deprecated get_event_loop() method. In Python 3.10+, it's recommended to use asyncio.run() instead of manually creating and managing an event loop. This is simpler and handles loop cleanup automatically.

Suggested change

	loop = asyncio.get_event_loop()
	try:
	loop.run_until_complete(main())
	finally:
	loop.close()
	asyncio.run(main())

[Copilot]

This class does not call Camera.init during initialization. (Libcamera.init may be missing a call to a base class init)

Suggested change

	def __init__(self, path, *args, **kwargs) -> None:
	def __init__(self, path, *args, **kwargs) -> None:
	super().__init__(*args, **kwargs)

[Copilot]

This class does not call Camera.init during initialization. (UVC.init may be missing a call to a base class init)

Suggested change

	def __init__(self, path: str, *args, **kwargs) -> None:
	def __init__(self, path: str, *args, **kwargs) -> None:
	super().__init__(path, *args, **kwargs)

[Copilot]

'except' clause does nothing but pass and there is no explanatory comment.

Suggested change

	except ImportError:
	except ImportError:
	# The libcamera module is not installed; return empty controls.

[Copilot]

'except' clause does nothing but pass and there is no explanatory comment.

Suggested change

	except FileNotFoundError:
	except FileNotFoundError:
	# It's normal for /etc/mainsailos-release to be missing on some systems; ignore if not present.

[Copilot]

clone_ustreamer is cloning https://github.com/pikvm/ustreamer.git using the mutable master branch during install/update, then building and running that binary, which introduces a supply-chain risk. If the upstream GitHub repo or the network path is compromised, an attacker can ship malicious commits to master that will be transparently built and executed here (typically as root or with access to video devices). To mitigate this, pin CROWSNEST_USTREAMER_REPO_SHIP/CROWSNEST_USTREAMER_REPO_BRANCH to an immutable tag or commit SHA, or depend on a signed/package-managed ustreamer build instead of cloning a moving branch.