Fix: bound initial connect to avoid setup CancelledError (v0.3.1)#3
Merged
Conversation
Wrap device.initialise() in asyncio.timeout(DEVICE_TIMEOUT=30s) and raise ConfigEntryNotReady on TimeoutError (before BLEAK_EXCEPTIONS). CancelledError is never swallowed. establish_connection(max_attempts=3) so failures surface promptly. Matches core led_ble/yalexs_ble. Adds cannot_connect + connect_timeout tests; ruff + 44 pytest pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: On production HAOS the setup failed with a raw
asyncio.CancelledError(Setup of config entry 'HLK-LD2450_1B6F' ... cancelled). Root cause:establish_connectioncan block for minutes when the BLE proxy/device is briefly unreachable, so Home Assistant's bootstrap stage timeout cancelsasync_setup_entry(we only caughtBLEAK_EXCEPTIONS, not cancellation).Fix (matches core led_ble/yalexs_ble):
device.initialise()inasyncio.timeout(DEVICE_TIMEOUT=30s)and raiseConfigEntryNotReadyonTimeoutError(caught beforeBLEAK_EXCEPTIONS, which also containsasyncio.TimeoutError). HA then retries cleanly instead of cancelling.CancelledErroris deliberately never swallowed.establish_connection(max_attempts=3)so connect failures surface promptly.Tests: new
cannot_connect+connect_timeoutsetup tests. ruff clean, 44 pytest pass.Releases as v0.3.1 (manifest bumped, CHANGELOG).