Repository navigation
Picco/allow paying for rent #645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
999953c
a0774c2
fb6e73e
dae6cc4
7ecfc4a
533ccde
638622d
f6a0270
402e0b7
8d31a09
754663f
7943a7d
361b0da
33430a3
98351e7
56e05f5
399c37d
d12b74f
0d638f4
5ec5287
e64166c
07b170e
0c7a7cd
21f91d1
cf69692
c193be6
9dce1a9
9f0a972
7d635c4
bf366ae
a4984d4
fece0cd
cf9082a
6283d23
889c46e
22c1817
1058443
31b49e5
a81e9bb
7fd5ec6
2bdd9ff
908733f
37b9d32
b284277
c9c7f8d
fdbaed2
405d4ff
3e7b400
3bc011d
61d475a
14ecd09
8714d6a
ab75627
4ef27a0
7dd4665
ef698ee
ca4f9c7
7b5a481
765c31f
7490687
0279b24
5ebf091
d9d5ee5
77c33e1
2cea109
c0e98fb
9e9e14a
917f177
1f2d684
0b1b245
7880a7d
9f8a0b2
021ef0d
a8900e1
0a042a3
8f2e12b
82f4248
ae73b6d
e1e6b15
37d6839
e7c8a03
c6f75fd
7162b3b
5e66fa2
a7a1eaa
9118600
308c1ff
91683be
13b048e
54a434e
36157fe
1f11b83
3b9496a
968e82d
2cdfe4f
e80ffc3
4c29cd3
4d433fb
66432ad
87a00bb
30262bf
ee3a330
451effe
7a33748
33d984e
4ca66b9
7f027b4
a2694c9
ec29722
fabbc8a
c4f5dbd
9fc5335
46ee1ed
14228a6
c288d2b
006676a
f9f737c
bce0a82
89194b8
b627817
521fbc1
9d2ba69
ceb9bab
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| use log::{debug, trace}; | ||
| use log::*; | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧹 Nitpick | 🔵 Trivial Consider explicit imports for clarity. While wildcard imports ( 🤖 Prompt for AI Agents |
||
| use magicblock_metrics::metrics::{ | ||
| TRANSACTION_PROCESSING_TIME, TRANSACTION_SKIP_PREFLIGHT, | ||
| }; | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
Verify inconsistent log levels for similar error conditions.
The log level for account ensure failure was downgraded from
warntodebug, but Line 137 inread_accounts_with_ensurestill useswarn!for the same type of error. Both functions have identical error handling patterns and comments ("There is nothing we can do if fetching the account fails").Is this inconsistency intentional? If single-account failures warrant only debug-level logging, should multi-account failures also be downgraded? Alternatively, if ensure failures indicate operational issues (network problems, chain unavailability, etc.) that could lead to stale data being served, should both remain at
warnlevel?Please clarify:
debughide important operational issues that need monitoring?🏁 Script executed:
Length of output: 1968
Ensure consistent log levels for semantically equivalent errors.
Verification confirms the log level inconsistency between
read_account_with_ensure(line 115:debug!) andread_accounts_with_ensure(line 137:warn!). Both functions have identical error handling logic and the same recovery comment ("There is nothing we can do if fetching the account(s) fails"), yet they log at different levels.Either:
Without explicit documentation, this inconsistency suggests an oversight and could unintentionally suppress observability into chain/network issues.
🤖 Prompt for AI Agents