Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We now accept native v1 transactions through ER RPC and preserve their signed bytes and resource configuration through execution, ledger persistence, replay, and history. ER transaction fees are always zero; base-layer settlement fees and program-specific commit charges are unchanged.
getFeeForMessageuse native message and transaction encoding. Signature, replay, blockhash, authority, and sanitization checks remain in place; v0 address lookup tables remain unsupported.maxSupportedTransactionVersionand reports unsupported encoding/version errors rather than returningnull.112182c143702d05a593101abaa7d437a0abb484, the Agave 4.2.2 port in SVM #34. Neither workspace depends on a sibling SVM checkout.Closes #1751.
Breaking Changes
--basefee,validator.basefee, and equivalent environment overrides. Remove these settings from deployments; ER fees are no longer configurable. Runtime/test-helper fee arguments and local committor v1 shim types are also removed. Consumers must align with the Agave 4.2.2 SDK/runtime baseline.Test Plan
Reviewer notes
This PR is based on #1764 and depends on SVM #34. Prior coordinated validation covered both workspaces, the full unit suite, and mixed-version ledger replay across restart; the published dependency pin and updated parent are checked with targeted validation here. Broad post-rebase coverage belongs in CI.
Critical-path costs have not been benchmarked. Trusted raw builtin account mutation remains outside normal runtime resize guards; the SVM port retains that trust boundary.