Repository navigation
ci: make prepare-release lockfile validation real - #1571
GabrielePicco wants to merge 1 commit into
Conversation
cargo metadata --no-deps skips dependency resolution, so --locked never validated the lockfiles and a stale test-integration/Cargo.lock could reach the release PR unnoticed. Resolve the full graph in both workspaces so a stale lockfile fails the prepare step instead of CI on the generated PR.
|
Warning Review limit reached
Next review available in: 50 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Problem
The release PR #1570 was created with a stale
test-integration/Cargo.lock, so every--lockedCI build on it failed.Two things lined up:
devbranch, so its old copy ofprepare-release.ymlran (workflow_dispatch executes the definition on the dispatched ref): that copy only builds the root workspace, so the test-integration lockfile was never refreshed after the version bump. Theif: ref == default branchguard only exists in master's newer copy, which didn't run.cargo metadata --locked --no-deps— is vacuous:--no-depsskips dependency resolution entirely, so--lockednever trips. The same vacuous check is still present in master's copy.Change
Drop
--no-depsfrom both verification calls socargo metadata --lockedresolves the full graph in both workspaces — a stale lockfile now fails the prepare step loudly instead of surfacing as CI failures on the generated release PR.A companion PR syncs this workflow to
devso a dispatch from there can no longer run the outdated definition.#1570 itself has been fixed by committing the refreshed
test-integration/Cargo.lock.