Skip to content

ci: make prepare-release lockfile validation real - #1571

Closed
GabrielePicco wants to merge 1 commit into
masterfrom
fix/prepare-release-lock-validation
Closed

GabrielePicco wants to merge 1 commit into
masterfrom
fix/prepare-release-lock-validation

Conversation

@GabrielePicco

Copy link
Copy Markdown
Collaborator

Problem

The release PR #1570 was created with a stale test-integration/Cargo.lock, so every --locked CI build on it failed.

Two things lined up:

  1. The workflow was dispatched from the dev branch, so its old copy of prepare-release.yml ran (workflow_dispatch executes the definition on the dispatched ref): that copy only builds the root workspace, so the test-integration lockfile was never refreshed after the version bump. The if: ref == default branch guard only exists in master's newer copy, which didn't run.
  2. Its lockfile "validation" — cargo metadata --locked --no-deps — is vacuous: --no-deps skips dependency resolution entirely, so --locked never trips. The same vacuous check is still present in master's copy.

Change

Drop --no-deps from both verification calls so cargo metadata --locked resolves the full graph in both workspaces — a stale lockfile now fails the prepare step loudly instead of surfacing as CI failures on the generated release PR.

A companion PR syncs this workflow to dev so a dispatch from there can no longer run the outdated definition.

#1570 itself has been fixed by committing the refreshed test-integration/Cargo.lock.

cargo metadata --no-deps skips dependency resolution, so --locked never
validated the lockfiles and a stale test-integration/Cargo.lock could
reach the release PR unnoticed. Resolve the full graph in both
workspaces so a stale lockfile fails the prepare step instead of CI on
the generated PR.
@coderabbitai

coderabbitai Bot commented Aug 15, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@GabrielePicco, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 50 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 5e7c6835-b5b8-4c5b-a34f-5a7770bf410c

📥 Commits

Reviewing files that changed from the base of the PR and between 4ca4a25 and 5bb6120.

📒 Files selected for processing (1)
  • .github/workflows/prepare-release.yml

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@bmuddha
bmuddha deleted the fix/prepare-release-lock-validation branch September 19, 2026 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant