Skip to content

Include committed accounts in CommitSent #829

Closed as not planned
Closed as not planned

Description

@taco-paco

Outcome

Include committed accounts in CommitSent.

Scope

Request
CommitSent now doesn't take a committed accounts as arguments. As a result it is not reflected in the history of TXs for a particular committed account.

Acceptance criteria

  • The outcome is implemented and validated.

Activity

  1. self-assigned this
    on Jan 13, 2026
  2. added theissue type on Aug 6, 2026
  3. changed the title [-]feat: CommitSent includes committed accounts as readonly[/-] [+]Include committed accounts in CommitSent[/+] on Aug 12, 2026
  4. assigned and unassigned on Sep 9, 2026
  5. bmuddha commented on Sep 17, 2026

    @bmuddha
    Collaborator

    Closing as not planned because the requested behavior is ambiguous, not because it has been implemented.

    Source review of current dev (073cd6e):

    The unresolved contract is whether address history should include all originally scheduled accounts or only accounts actually included in the commit. This matters because the normal notification is pre-signed before the execution result is known.

    If revisited, define that account set explicitly and require ScheduledCommitSent discoverability through getSignaturesForAddress across normal, recovered, and expired-blockhash fallback paths.

    These findings are source-level; no runtime reproduction was performed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions