feat: hardening action and callback instructions

crank-counter/anchor/programs/crank-counter/src/lib.rs

@@ -30,6 +30,9 @@ pub mod anchor_counter {
         Ok(())
     }
 
+    // This example intentionally keeps `increment` permissionless. A privileged scheduled
+    // instruction must authenticate the preceding Hydra `Trigger` through the instructions
+    // sysvar. Scheduled instructions run top-level and do not inherit a Hydra PDA signature.
     /// Increment the counter.
     pub fn increment(ctx: Context<Increment>) -> Result<()> {
         let counter = &mut ctx.accounts.counter;

delegation-actions/anchor/programs/delegation-actions/src/lib.rs

@@ -22,6 +22,9 @@ pub mod delegation_actions {
         Ok(())
     }
 
+    // This example intentionally keeps `increment` permissionless. A privileged
+    // post-delegation action should require an action signer that was validated and recorded
+    // when the account was delegated, or check an authority stored in program state.
     pub fn increment(ctx: Context<Increment>) -> Result<()> {
         let counter = &mut ctx.accounts.counter;
         counter.count += 1;

magic-actions/anchor/programs/magic-actions/src/lib.rs

@@ -127,6 +127,10 @@ pub struct Increment<'info> {
     pub counter: Account<'info, Counter>,
 }
 
+    // `#[action]` adds the action accounts but does not authenticate the caller.
+    // This example intentionally leaves `update_leaderboard` public. A privileged handler
+    // must constrain `escrow_auth` to an expected authority and require the derived `escrow`
+    // PDA as a signer, or require an authority stored in program state.
 #[action]
 #[derive(Accounts)]
 pub struct UpdateLeaderboard<'info> {

roll-dice/pinocchio/programs/roll-dice-delegated/src/processor.rs

@@ -124,6 +124,12 @@ pub fn process_callback_roll_dice(
         return Err(ProgramError::InvalidSeeds);
     }
 
+    // The scoped identity address is public. Its signer privilege proves that the
+    // VRF program invoked this callback. 
+    if !program_identity.is_signer() {
+        return Err(ProgramError::MissingRequiredSignature);
+    }
+
     let rnd_u8 = random_u8_with_range(&randomness, 1, 6);
     pinocchio_log::log!("Consuming random number: {}", rnd_u8);
     pinocchio_log::log!("client_seed={}", client_seed);

roll-dice/pinocchio/programs/roll-dice/src/processor.rs

@@ -118,6 +118,12 @@ pub fn process_callback_roll_dice(
         return Err(ProgramError::InvalidSeeds);
     }
 
+    // The scoped identity address is public. Its signer privilege proves that the
+    // VRF program invoked this callback.
+    if !program_identity.is_signer() {
+        return Err(ProgramError::MissingRequiredSignature);
+    }
+
     let rnd_u8 = random_u8_with_range(&randomness, 1, 6);
     pinocchio_log::log!("Consuming random number: {}", rnd_u8);
     pinocchio_log::log!("client_seed={}", client_seed);